-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to om.next #18
Conversation
Looks like I messed this one up. A lot of code was still pre-loaded so it seemed to work when in reality it didn't. To make it work, we need to abstract Afterwards we'll have to get rid of |
David was kind enough to push alpha10 last-minute for us to experiment with. It adds support to specify a separate render / unmount function that we can use with react native. It still doesn't work out of the box and needs another small change inside I'm confident that with the next alpha (alpha11?) we can get it running out of the box. I'll update my PR once that's out. |
Excellent work, and a perfect way to get familiar with Om Next. I've been planning on adding an option to Natal that allows you to specify which React wrapper to use for the app skeleton. Once that's done and your changes are working without having to patch Om, we can merge this in and give users the option between Om Now and Om Next (and eventually others) during the init phase. Thanks for doing the trailblazing here. |
As soon as I mentioned it in the om slack David pushed alpha11 with the needed changes. With that it now works out of the box 😊 |
I added the ability to switch React interface templates like this:
Om stable is still the default, but we'll probably switch to Om Next once it's ready. Thanks again for the PR. |
Maybe related: #17
I'm playing a lot with om.next lately and found that it works fairly good in natal / react native as well. We should probably wait before merging this in until next hits stable, but this code works great as reference.