Skip to content

Dejan Muhamedagic
dmuhamedagic

May 31, 2016
@dmuhamedagic
May 31, 2016
dmuhamedagic merged pull request ClusterLabs/booth#42
@dmuhamedagic
maint: clarify GPLv2+ in the license notices from an earlier PR
1 commit with 24 additions and 24 deletions
May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

Why is here "crm_resource --wait" in the extra invocation? There may also be a race condition if the PE doesn't change the state before the second …

May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

On Tue, May 31, 2016 at 06:25:58AM -0700, Jan Pokorný wrote: } repair_external_prog() { run_site $1 crm configure delete $PREFNAME local cmd …

May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

You could then add here: . blah/pcmk_${cli_driver}.sh

May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

Just curious, what's the function of '|| :' ?

May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

This makes the code unwieldy. Could you please instead move these functions to three separate files which are then to be sourced depending on the m…

May 31, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#41
@dmuhamedagic

This seems to me rather confusing. After all, one is the crmsh script, whereas the addition is in the form of shell commands. Could you please add …

May 30, 2016
@dmuhamedagic
May 30, 2016
dmuhamedagic merged pull request ClusterLabs/booth#22
@dmuhamedagic
Feature: offer glue alternatives
6 commits with 560 additions and 35 deletions
May 19, 2016
@dmuhamedagic
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#40
@dmuhamedagic
High-ranked fixes
1 commit with 2 additions and 2 deletions
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#39
@dmuhamedagic
[static analysis] fix list_ticket memleak
2 commits with 4 additions and 3 deletions
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#38
@dmuhamedagic
[static analysis] close lock file when no longer needed
4 commits with 10 additions and 12 deletions
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#37
@dmuhamedagic
[static analysis] close config file when no longer needed
2 commits with 9 additions and 6 deletions
May 19, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#40
@dmuhamedagic

The issue got introduced much earlier, just got copied over in the referenced commit. The reason this never turned into a bug with consequences is …

May 19, 2016
@dmuhamedagic
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#36
@dmuhamedagic
Med-ranked fixes
3 commits with 6 additions and 4 deletions
May 19, 2016
dmuhamedagic closed pull request ClusterLabs/booth#35
@dmuhamedagic
Low-ranked fixes
May 19, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#35
@dmuhamedagic

Merged. Thanks!

May 19, 2016
@dmuhamedagic
May 19, 2016
@dmuhamedagic
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#31
@dmuhamedagic
unit tests: making them passing
4 commits with 8 additions and 6 deletions
May 19, 2016
@dmuhamedagic
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#32
@dmuhamedagic
build: ensure expected behavior if --without-html_man not provided
1 commit with 3 additions and 1 deletion
May 19, 2016
@dmuhamedagic
  • @jnpkrn d2b981f
    docs: licensing conformance follow-up (man pages)
May 19, 2016
dmuhamedagic merged pull request ClusterLabs/booth#33
@dmuhamedagic
docs: licensing conformance follow-up (man pages)
1 commit with 8 additions and 5 deletions
May 19, 2016
dmuhamedagic commented on pull request ClusterLabs/booth#22
@dmuhamedagic

@LOGGER@ not being replaced. You probably forgot.

May 18, 2016
dmuhamedagic commented on pull request ClusterLabs/resource-agents#809
@dmuhamedagic

On Wed, May 18, 2016 at 09:04:12AM -0700, Kristoffer Grönlund wrote: So maybe the reason to avoid -a is folklore, but here is a justification I fo…

May 18, 2016
dmuhamedagic commented on pull request ClusterLabs/resource-agents#809
@dmuhamedagic

IIRC, -a for AND is not in the POSIX standard. '-a' is common. Documented in http://www.unix.com/man-page/posix/1p/test/ too. if [ -f $script ] …

Something went wrong with that request. Please try again.