Add clientToolName middleware #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache-monet
reviewed
Mar 21, 2019
| class ClientToolNameMiddleware(BaseMiddleware): | ||
| def __init__(self, name="pythx"): | ||
| LOGGER.debug("Initializing") | ||
| self.name = name |
Contributor
There was a problem hiding this comment.
Are we planning to add additional middleware or allow devs to build custom ones off of PythX?
Contributor
Author
There was a problem hiding this comment.
Developers can add their own middlewares, simply by adding them to the APIHandler, like
from foo import MyMiddleware
from pythx.api.handler import APIHandler
mw = MyMiddleware()
handler = APIHandler(middlewares=[mw])and then passing that to the Client class. I'm also hacking up a passthrough so you can do something like
c = Client(middlewares=[mw])to completely abstract from the API handler class.
cache-monet
reviewed
Mar 21, 2019
| (CUSTOM_CTN_MIDDLEWARE, generate_request_dict(testdata.LOGOUT_REQUEST_OBJECT), False), | ||
| (CUSTOM_CTN_MIDDLEWARE, generate_request_dict(testdata.REFRESH_REQUEST_OBJECT), False), | ||
| ], | ||
| ) |
cache-monet
previously approved these changes
Mar 21, 2019
Contributor
cache-monet
left a comment
cache-monet
left a comment
There was a problem hiding this comment.
Really good stuff, I'm learning a lot just by reviewing the code 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a middleware that automatically fills in the
clientToolNamefield of analysis submission requests so people on the API side know PythX was used.