Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Link BaseElements to parent Page for file used on table #827

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 25, 2020

@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch 3 times, most recently from c4a79f7 to ac09b07 Compare September 29, 2020 23:56
@emteknetnz emteknetnz changed the title Link BaseElements to parent Page for file used on table ENH Link BaseElements to parent Page for file used on table Oct 14, 2020
@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch from ac09b07 to 26af713 Compare October 14, 2020 21:59
@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch 2 times, most recently from 4efbd9a to bf58945 Compare October 27, 2020 23:52
@Cheddam
Copy link
Member

Cheddam commented Nov 2, 2020

@emteknetnz Might need to tweak the build matrix to get this green, as it's trying to reference a dev branch that has been removed.

@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch from bf58945 to 2ee4125 Compare November 2, 2020 22:07
Copy link
Member

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty happy with this as-is, just a couple of questions.

.travis.yml Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch 5 times, most recently from 6149292 to c596a11 Compare November 3, 2020 22:42
@emteknetnz emteknetnz force-pushed the pulls/4/update-used-on-table-extension branch from c596a11 to 293dcb4 Compare November 3, 2020 22:48
@Cheddam Cheddam merged commit 6a40c41 into silverstripe:4 Nov 4, 2020
@Cheddam Cheddam deleted the pulls/4/update-used-on-table-extension branch November 4, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants