Remove "RUN go get" from DockerFile in Go-Postgres container #4
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add go.mod and go.sum files make dockerfile 'RUN go get' optional
bderusha
force-pushed
the
bderusha/go-mod
branch
from
ba36e14
to
cbc04e9
Compare
|
Closed this PR as this branch was merged into microsoft-main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in reference to bug AzDO 23066
Result of spike-task: using
go modcommands was straightforward to create go.mod and go.sum files that enablego runcommands to correctly download and use dependencies + references.Impact: we de-coupled the go-module(s) "dependency declaration" from the image itself, which is consistent with other containers (i.e. see python containers using environment.yml in DockerFile)
Estimate for fix: a local PR is ready, so mainly review time & confirming approach w/ Chuck