Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clhash checkout command #14

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@luizirber
Copy link
Contributor

luizirber commented Mar 6, 2019

Hello,

while trying to build dashing using the instructions:

git clone https://github.com/dnbaker/dashing
cd dashing && make update dashing

I got an error (on an Arch Linux system running zsh) during the clhashcompilation:

cd bonsai/bonsai && make clhash.o && cd ../..
make[1]: Entering directory 'dashing/bonsai/bonsai'
ls clhash.o 2>/dev/null || mv ../clhash/clhash.o . 2>/dev/null || (cd ../clhash "&& git checkout master" && make && cd ../bonsai && ln -s ../clhash/clhash.o .)
/bin/sh: line 0: cd: too many arguments
make[1]: *** [Makefile:88: clhash.o] Error 1

Removing the quotes fixes the problem. (I also saw a similar line is in the dashing Makefile, but it is not used so it doesn't trigger the problem).

@dnbaker

This comment has been minimized.

Copy link
Owner

dnbaker commented Mar 6, 2019

Hi Luiz,

Thanks for finding this! Looks like it's an error that all the OSes we've tested on haven't been able to catch. (Obviously, there shouldn't be quotation marks around that, but I guess they've been friendly about it.)

You're right, that line isn't used in Dashing (we just have bonsai build it, which makes it more maintainable than keeping solutions in two repos), and it will be removed soon.

Thanks!

Daniel

@dnbaker dnbaker merged commit 82254dd into dnbaker:master Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.