Installation Wizard: Fix endless loop trying to request .../images/brand... #122

Merged
merged 3 commits into from Jul 10, 2014

Conversation

Projects
None yet
4 participants
@janjonas
Contributor

janjonas commented Jul 2, 2014

If the IIS "Anonymous Authentication Identity" has no read permission on file system there is an endless loop in the Installation Wizard that tries to load the file /images/branding/DNN_logo.png again and again. In detail, the onerror trigger for the banner image is fired, the handler changes the image source and the onerror trigger is fired again.

Of course the installation is completely broken (as described here http://blog.janjonas.net/2014-07-02/dotnetnuke-fix-broken-installation-wizard) but this endless loop makes it hard to debug because the browser console is flooded and it seems, that the page does not stop loading (tested in Firefox 30).

Installation Wizard: Fix endless loop trying to request .../images/br…
…anding/DNN_logo.png when IIS "Anonymous Authentication Identity" has no read permission on file system
@janjonas

This comment has been minimized.

Show comment
Hide comment
@janjonas

janjonas Jul 3, 2014

Contributor

I've created Jira ticket DNN-5561 (https://dnntracker.atlassian.net/browse/DNN-5561)

Contributor

janjonas commented Jul 3, 2014

I've created Jira ticket DNN-5561 (https://dnntracker.atlassian.net/browse/DNN-5561)

@cathalconnolly

This comment has been minimized.

Show comment
Hide comment
@cathalconnolly

cathalconnolly Jul 3, 2014

thanks Jan - can you please assign yourself to the ticket to ensure that no-one else accidentally works on (FYI the recommended process can be read at https://github.com/dnnsoftware/Dnn.Platform/blob/master/CONTRIBUTING.md )

thanks Jan - can you please assign yourself to the ticket to ensure that no-one else accidentally works on (FYI the recommended process can be read at https://github.com/dnnsoftware/Dnn.Platform/blob/master/CONTRIBUTING.md )

@janjonas

This comment has been minimized.

Show comment
Hide comment
@janjonas

janjonas Jul 3, 2014

Contributor

Unfortunately, I do not have the JIRA permission to assign the ticket to me or to start progress...

Contributor

janjonas commented Jul 3, 2014

Unfortunately, I do not have the JIRA permission to assign the ticket to me or to start progress...

@cathalconnolly

This comment has been minimized.

Show comment
Hide comment
@cathalconnolly

cathalconnolly Jul 3, 2014

odd - we did have a jira issue with a recent upgrade that Atlassian have resolved. We kicked off a reindex of the users to ensure they got the new profiles, so perhaps try logging out then back in again. If that doesn't help, I'll check with our Jira admin and see if I can track down the issue (it may be that the permission has never been in place as many of the pull requests are done by MVP's and they have more permissions than normal Jira users)

odd - we did have a jira issue with a recent upgrade that Atlassian have resolved. We kicked off a reindex of the users to ensure they got the new profiles, so perhaps try logging out then back in again. If that doesn't help, I'll check with our Jira admin and see if I can track down the issue (it may be that the permission has never been in place as many of the pull requests are done by MVP's and they have more permissions than normal Jira users)

@janjonas

This comment has been minimized.

Show comment
Hide comment
@janjonas

janjonas Jul 3, 2014

Contributor

Tried to logout and login again... same problem: I'm not able to change the ticket assignee.

Contributor

janjonas commented Jul 3, 2014

Tried to logout and login again... same problem: I'm not able to change the ticket assignee.

@BobKruger

This comment has been minimized.

Show comment
Hide comment
@BobKruger

BobKruger Jul 4, 2014

Hi Jan. You do not have a role in which you can be assigned a task. Only a select few people outside of DNN Corp have this role. However, you can state in the JIRA comments section that you are working on a fix for this issue and that you will advise when done. Any watcher will see your comment and know to take the JIRA to the next step in the workflow. Thanks, in advance, for your contribution!

Hi Jan. You do not have a role in which you can be assigned a task. Only a select few people outside of DNN Corp have this role. However, you can state in the JIRA comments section that you are working on a fix for this issue and that you will advise when done. Any watcher will see your comment and know to take the JIRA to the next step in the workflow. Thanks, in advance, for your contribution!

@janjonas

This comment has been minimized.

Show comment
Hide comment
@janjonas

janjonas Jul 5, 2014

Contributor

Thanks Bob for your feedback.
I'm not working on the issue. I already created the pull request that fixes the problem. What should I do now? Add a comment in the JIRA ticket that I'm done and somebody can review my changes?

Contributor

janjonas commented Jul 5, 2014

Thanks Bob for your feedback.
I'm not working on the issue. I already created the pull request that fixes the problem. What should I do now? Add a comment in the JIRA ticket that I'm done and somebody can review my changes?

@BobKruger

This comment has been minimized.

Show comment
Hide comment
@BobKruger

BobKruger Jul 5, 2014

Great! Adding a comment to JIRA and assigning to Cathal would be helpful. I’ve copied him here so he knows.

Thanx!

-Bob

BOB KRUGER
SVP Engineering
DNN Corp.
http://www.dnnsoftware.com/www.dnnsoftware.comhttp://www.dnnsoftware.com/

m +1 408-421-8153
o +1 650-288-3687
Twitterhttps://twitter.com/DNNCorp | Facebookhttps://www.facebook.com/dotnetnuke?fref=ts | LinkedInhttp://www.linkedin.com/company/207975 | Google+https://plus.google.com/+dotnetnuke/posts

On Jul 5, 2014, at 2:32 AM, janjonas <notifications@github.commailto:notifications@github.com> wrote:

Thanks Bob for your feedback.
I'm not working on the issue. I already created the pull request that fixes the problem. What should I do now? Add a comment in the JIRA ticket that I'm done and somebody can review my changes?


Reply to this email directly or view it on GitHubhttps://github.com/dnnsoftware/Dnn.Platform/pull/122#issuecomment-48082235.

Great! Adding a comment to JIRA and assigning to Cathal would be helpful. I’ve copied him here so he knows.

Thanx!

-Bob

BOB KRUGER
SVP Engineering
DNN Corp.
http://www.dnnsoftware.com/www.dnnsoftware.comhttp://www.dnnsoftware.com/

m +1 408-421-8153
o +1 650-288-3687
Twitterhttps://twitter.com/DNNCorp | Facebookhttps://www.facebook.com/dotnetnuke?fref=ts | LinkedInhttp://www.linkedin.com/company/207975 | Google+https://plus.google.com/+dotnetnuke/posts

On Jul 5, 2014, at 2:32 AM, janjonas <notifications@github.commailto:notifications@github.com> wrote:

Thanks Bob for your feedback.
I'm not working on the issue. I already created the pull request that fixes the problem. What should I do now? Add a comment in the JIRA ticket that I'm done and somebody can review my changes?


Reply to this email directly or view it on GitHubhttps://github.com/dnnsoftware/Dnn.Platform/pull/122#issuecomment-48082235.

@cathalconnolly

This comment has been minimized.

Show comment
Hide comment
@cathalconnolly

cathalconnolly Jul 5, 2014

Jan - you don't need to do anything else. Historically many of the pull requests were by MVP's who had the ability to assign themselves, but we've amended the process to just ask user's to add a comment to note that a pull request is forthcoming (or already there). We will have our standard pull-request review meeting next week and process the change then. Thanks

Jan - you don't need to do anything else. Historically many of the pull requests were by MVP's who had the ability to assign themselves, but we've amended the process to just ask user's to add a comment to note that a pull request is forthcoming (or already there). We will have our standard pull-request review meeting next week and process the change then. Thanks

@cathalconnolly

This comment has been minimized.

Show comment
Hide comment
@cathalconnolly

cathalconnolly Jul 10, 2014

merging into 7.3.2

merging into 7.3.2

cathalconnolly pushed a commit that referenced this pull request Jul 10, 2014

Cathal Connolly Cathal Connolly
Merge pull request #122 from janjonas/development
Installation Wizard: Fix endless loop trying to request .../images/brand...

@cathalconnolly cathalconnolly merged commit 671739e into dnnsoftware:development Jul 10, 2014

@jbrinkman jbrinkman added the merged label Aug 4, 2014

@jbrinkman jbrinkman added this to the 7.3.2 milestone Aug 4, 2014

@jbrinkman jbrinkman added the nop label Jan 11, 2015

@jbrinkman jbrinkman added Community and removed nop labels Mar 3, 2015

@jbrinkman jbrinkman added nop and removed nop labels Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment