Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNN-5800, DNN-5801 (#149) corrected #150

Closed
wants to merge 1 commit into from
Closed

DNN-5800, DNN-5801 (#149) corrected #150

wants to merge 1 commit into from

Conversation

sleupold
Copy link
Contributor

@sleupold sleupold commented Sep 3, 2014

Correct missing databaseOwner/ObjectQualifier and added another sproc (MoveTabToParent) with same bug

@sleupold
DNN-5800, DNN-5801 corrected
c295507 
Corrent missing databaseOwner/ObjectQualifier and added another sproc (MoveTabToParent) with same bug
@sleupold sleupold changed the title DNN-5800, DNN-5801 corrected DNN-5800, DNN-5801 (#149) corrected Sep 3, 2014
@vmasanas
Copy link
Contributor

vmasanas commented Sep 3, 2014

MoveTabToParent was already part of my previous fix. I think it would be better if you just reported the missing pieces to the original submitter so I could correct my initial commits for the other pieces.

@sleupold
Copy link
Contributor Author

sleupold commented Sep 3, 2014

sorry, I might need to get more acquainted with GitHub.
Procdure code includes slight optimizations.

@vmasanas
Copy link
Contributor

vmasanas commented Sep 4, 2014

I've reviewed this code and it introduces additional bugs. I've fixed my branch with the missing {databaseOwner}{objectQualifier} as you reported. So I suppose this pull request could just be closed.

@sleupold
Copy link
Contributor Author

sleupold commented Sep 4, 2014

I have no problems of you using your own version. It was just a suggestion.

@vmasanas
Copy link
Contributor

vmasanas commented Sep 4, 2014

Sebastian, that's not the point. What I'm saying is that your version introduced more bugs and I couldn't fix them without introducing much more noise here.
If you think you can contribute to the code please make comments on the original pull request, makes far more easier to manage.
This has nothing to do with performance or not wanting your contributions. It's just to make it manageable.

@sleupold sleupold closed this Sep 4, 2014
@jbrinkman jbrinkman added the nop label Jan 11, 2015
@jbrinkman jbrinkman added Community Legacy label used to identify community contributions and removed nop labels Mar 3, 2015
@jbrinkman jbrinkman added nop and removed nop labels Nov 3, 2015
valadas referenced this pull request in valadas/Dnn.Platform Oct 2, 2019
@tpluscode
Create issue templates (#150)
997a5ab 
* Create bug-report.md

Add bug report for issue template

* Create feature-request.md

Add feature request issue template

* Create help-and-other-questions.md

Add help and other questions issue template.
bdukes added a commit to bdukes/Dnn.Platform that referenced this pull request Sep 18, 2020
@bdukes
Merge pull request dnnsoftware#150 from UpendoVentures/issues/issue-149
6c26722 
Fixes dnnsoftware#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Community Legacy label used to identify community contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleupold @vmasanas @jbrinkman