Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module find logic in module attribute #3464

Merged
merged 1 commit into from Jan 12, 2020
Merged

Fix module find logic in module attribute #3464

merged 1 commit into from Jan 12, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Jan 10, 2020

Current logic ignores module's status when finding it

mitchelsellers
mitchelsellers approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valadas valadas added this to the 9.5.0 milestone Jan 12, 2020
@valadas valadas merged commit 984af87 into dnnsoftware:develop Jan 12, 2020
@donker donker deleted the fix-202001-1 branch January 15, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donker @bdukes @mitchelsellers @valadas