Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view command shouldn't require book name #161

Closed
sungwoncho opened this issue Jan 27, 2019 · 2 comments

Comments

@sungwoncho
Copy link
Member

commented Jan 27, 2019

View command takes book name as the first argument but that requirement is redundant because the command takes a unique note id as the third argument. For instance,

dnote v myBook 123

might well be

dnote v 123

because 123 is a unique identifier for a note.

The intention for taking book name as an argument was to save users from typing dnote view in the following scenario:

dnote v myBook
# ...result is shown...
# user presses up key, and types the note id
dnote v myBook 123

But the scenario does not happen as often. Also it is inconvenient to have to type book name after using the find command.

  • this change means that book name can't be integer. Need to migrate both client and server side for book names that violate this condition.

plan:

  • support view command with a single argument
  • deprecate two arguments
  • release 0.6.0
@sungwoncho

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

In progress in simple-view branch. Not a huge priority.

@sungwoncho

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

Fixed by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.