New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xiwi: patch with xf86-video-dummy-0.3.8 #2953

Merged
merged 3 commits into from Feb 21, 2017

Conversation

Projects
None yet
7 participants
@nxtr
Copy link
Contributor

nxtr commented Dec 16, 2016

Xiwi fails on distro sid and stretch due to:
/usr/lib/xorg/Xorg: symbol lookup error: /usr/lib/xorg/modules/drivers/dummy_drv.so: undefined symbol: ChangeWindowProperty
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845728

Xiwi updated to patch from xf86-video-dummy-0.3.8 source to match
https://packages.debian.org/source/sid/xserver-xorg-video-dummy

Works like a charm for sid, stretch. Also tested successfully on jessie (0.3.7-1) and wheezy (0.3.5-2) and since the package version was faked to 0.3.8 I believe we're good to go.

@arj03

This comment has been minimized.

Copy link

arj03 commented Dec 20, 2016

Ran into this problem. Would be nice with a merge 👍

@middleagedman

This comment has been minimized.

Copy link

middleagedman commented Jan 17, 2017

Can someone please review and approve this so we can get our X back? Thanks!

@jcao219

This comment has been minimized.

Copy link

jcao219 commented Jan 18, 2017

Is there a way to apply this change manually? I would like my X back a little early if possible.

@DennisLfromGA

This comment has been minimized.

Copy link
Collaborator

DennisLfromGA commented Jan 18, 2017

@jcao219,

See this comment for earlybird instructions: #2997 (comment)

And, like @jernic mentions, be sure to update your chroot afterwards.

Hope this helps,
-DennisL

@jcao219
Copy link

jcao219 left a comment

Fixes the issue on Debian stretch.

@dnschneid

This comment has been minimized.

Copy link
Owner

dnschneid commented Feb 17, 2017

Could you please clean up the patch so there aren't a bunch of whitespace changes?

@nxtr

This comment has been minimized.

Copy link
Contributor

nxtr commented Feb 18, 2017

@dnschneid ws cleanup done

@middleagedman

This comment has been minimized.

Copy link

middleagedman commented Feb 21, 2017

No idea why I have approval rights lol

@dnschneid

This comment has been minimized.

Copy link
Owner

dnschneid commented Feb 21, 2017

Thanks for the approval, @middleagedman :)

@drinkcat: do we need to bump the fake version to 0.3.9, or does it not really matter?

Also, now that apparently dummy has gotten updated upstream, does anyone (@drinkcat, @nxtr) want to try again to get this patch upstreamed?

@dnschneid dnschneid merged commit 2541aeb into dnschneid:master Feb 21, 2017

@drinkcat

This comment has been minimized.

Copy link
Collaborator

drinkcat commented Feb 21, 2017

@drinkcat: do we need to bump the fake version to 0.3.9, or does it not really matter?

Yes, we should update it.

Also, now that apparently dummy has gotten updated upstream, does anyone (@drinkcat, @nxtr) want to try again to get this patch upstreamed?

Aaron Plattner submitted a better alternative to my patch: https://lists.x.org/archives/xorg-devel/2015-January/045395.html, which, also, didn't get merged... I see some recent activity about it on the list about them though, so I'm not too sure where we are now and what still needs to be done.

If anyone wants to give it a second try at upstreaming, please go for it ,-)

@nxtr

This comment has been minimized.

Copy link
Contributor

nxtr commented Feb 22, 2017

@drinkcat: do we need to bump the fake version to 0.3.9, or does it not really matter?

Yes, we should update it.

Ahh, understod. I'm on it!

If anyone wants to give it a second try at upstreaming, please go for it ,-)

Nah, not me. I'm just pushing versions :) Besides, looking into it, there are re/new patches submitted recently: https://patchwork.freedesktop.org/series/16453/. Let's watch this space.

Great stuff guys :)

@dnschneid

This comment has been minimized.

Copy link
Owner

dnschneid commented Feb 23, 2017

That resubmission of patches dropped the one we were interested in...oh well, at least if that gets merged, the delta to the last patch will be smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment