New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'name' property #56

Closed
martinisoft opened this Issue Jun 12, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@martinisoft
Member

martinisoft commented Jun 12, 2018

Per some new foodcritic rules, specifically FC120 we need to not set the name property directly on the record resource. We'll probably want to rename it to record_name instead.

@martinisoft martinisoft added the bug label Jun 12, 2018

martinisoft added a commit that referenced this issue Jun 12, 2018

martinisoft added a commit that referenced this issue Aug 8, 2018

Upgrade to Chef 13.9+ and clean up resources (#57)
* Match on part of the exception, not the specifics

Less brittle this way

* Overhaul README to prepare for the coming changes

* Bump Chef to 13.9+

* Don't need this cop off now

* Rename an improperly named property

Closes #56

* Rename for consistency

* This was a potential bug for regional records

* kind_of is gone now in place of just types

* Reformat and fix property descriptions

* Don't need kind_of and some of these are sensitive

* Re-factor to use common_name and parse date

* Don't need to require a name property

* Add a deprecation note

* Bump to the trusty releases

* Update required properties

* Update integration test cases

* Remove install certificate suite

Per documentation and developer discussion, we don't issue valid SSL
certificates in the Sandbox environment so this cannot be accurately
tested without risking our own production environment. We may revisit
this again some day by making a separate special domain account for
testing.

* Add some more notes to README

* Simplify migration instructions

* Remove warning messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment