New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing records with different type on create #12

Merged
merged 9 commits into from Jan 14, 2014

Conversation

Projects
None yet
2 participants
@josacar
Contributor

josacar commented Jan 14, 2014

Create method on record LWRP doesn't match with the type of the record, so if any record with the same name will be deleted.

Given:

    A 1.1.1.1
    MX wadus
    NS 1.1.1.1
    CNAME wadus

and this lwrp call:

dnsimple_record '' do
  type 'CNAME'
  content 'newvalue'
  domain 'example.com'
  username 'user@email.com'
  password 'my123password'
end

This will raise on deleting the first record obtained from the API.

Closes #9

josacar added some commits Dec 24, 2013

Split each scenario to a simple recipe
This avoid hitting creating records with same id as
`lib/fog/dnsimple/requests/dns/create_record.rb` creates `id` from 0 to
10.
Point to latest fog revision make mocks work
This includes the commit a8268e90880da12696205238040a6e0b27ac47a7 that
fix the get_domain method to support being it called with the domain
name instead the id.
@josacar

This comment has been minimized.

Contributor

josacar commented Jan 14, 2014

I've also added travis-ci, so you can enable the integration when you can.

@dje

This comment has been minimized.

Contributor

dje commented Jan 14, 2014

Thank you! I'm excited to try this out. I think master moved forward a bit. Would you mind rebasing?

Merge remote branch 'upstream/master'
Conflicts:
	libraries/dnsimple.rb
	metadata.json
	metadata.rb
@josacar

This comment has been minimized.

Contributor

josacar commented Jan 14, 2014

Updated, there were three conflicts. If something needs to be moved out to other issue or discuss it, don't hesitate pinging me.

dje added a commit that referenced this pull request Jan 14, 2014

Merge pull request #12 from josacar/master
Avoid removing records with different type on create

@dje dje merged commit 8d7dda2 into dnsimple:master Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment