New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating record with multiple content values #20

Merged
merged 5 commits into from Oct 16, 2014

Conversation

Projects
None yet
3 participants
@josacar
Contributor

josacar commented Jul 9, 2014

Implement creating a DNS record name with multiple values, this is, creating one entry with the same name and each one with one different value.

Now the LWRP supports both String and Array values when setting content:

dnsimple_record 'multiple' do
  type 'A'
  content ['2.2.2.2', '3.3.3.3']
  domain 'example.com'
  username 'user@email.com'
  password 'my123password'
end

And creates the following DNS records:

multiple A 2.2.2.2 3600
multiple A 3.3.3.3 3660
@josacar

This comment has been minimized.

Contributor

josacar commented Jul 9, 2014

@aeden Let me know if there's anything to work it out

@josacar

This comment has been minimized.

Contributor

josacar commented Aug 3, 2014

@dje Ping

@aeden

This comment has been minimized.

Member

aeden commented Aug 3, 2014

@josacar @dje is no longer working on this library. I'll have @martinisoft take a look at it and see what he thinks, since he is probably the best person to answer at this point.

@josacar

This comment has been minimized.

Contributor

josacar commented Sep 2, 2014

@martinisoft @aeden Any update on still opened PRs?

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 2, 2014

Hi @josacar I'll take a look in a few and get this merged today.

@martinisoft martinisoft self-assigned this Sep 2, 2014

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 3, 2014

@josacar Can you merge against master to make sure things are still passing on Travis? Can see about merging for a 1.1 release.

josacar added some commits Sep 3, 2014

@josacar

This comment has been minimized.

Contributor

josacar commented Sep 3, 2014

Here we go!

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 3, 2014

This looks good @josacar would you mind updating the README to note this change?

@josacar

This comment has been minimized.

Contributor

josacar commented Oct 4, 2014

@martinisoft Is there anything else to be worked?

@martinisoft

This comment has been minimized.

Member

martinisoft commented Oct 6, 2014

@josacar Nope this is good to go. I'll be doing a bunch of merges and ship a release to the supermarket this week.

martinisoft added a commit that referenced this pull request Oct 16, 2014

Merge pull request #20 from josacar/feature/support-multiple-content-…
…values

Support creating record with multiple content values

@martinisoft martinisoft merged commit cf6772c into dnsimple:master Oct 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment