New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap fog gem for fog-dnsimple #42

Merged
merged 4 commits into from Sep 30, 2016

Conversation

Projects
None yet
2 participants
@martinisoft
Member

martinisoft commented Sep 29, 2016

To simplify and slim-down the fog gem, the DNSimple provider was extracted by @weppos into fog-dnsimple. So this is a fairly straightforward swap out since the API is the same as before. We'll eventually use the newer v2 API DNSimple gem, but as of today it is breaking for users of this cookbook since the fog gem no longer includes DNSimple as a default module.

@martinisoft martinisoft self-assigned this Sep 29, 2016

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 29, 2016

Ended up doing a few additional changes including the test suite which made an assumption that we still installed a fog binary. This is no longer the case with fog-core which is just the library and our adapter on top. This should fully pass and be ready to 🚢 soon @onlyhavecans 👍

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 29, 2016

Looks like we're passing finally. Waiting on a final review @onlyhavecans 👍

@martinisoft martinisoft merged commit e5dedfa into master Sep 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@martinisoft martinisoft deleted the bugfix/swap_fog_gem branch Sep 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment