New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all_certificates endpoint and fix certificates spec #53

Merged
merged 4 commits into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@martinisoft
Member

martinisoft commented Mar 21, 2018

This PR fixes two things:

  • Implements the all_certificates endpoint we added via dnsimple/dnsimple-ruby#155 and updates the specs
  • Fixes a really silly date bug in our certificate spec

martinisoft added some commits Mar 21, 2018

@martinisoft

This comment has been minimized.

Member

martinisoft commented Mar 21, 2018

And we're green again on tests 👍

I have also taken the liberty of adding a weekly cron to Travis-CI builds to re-test this cookbook to catch stuff like this sooner. It's been broken since January :(

@martinisoft martinisoft merged commit dbaff0b into master Mar 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@martinisoft martinisoft deleted the bugfix/certificates_testing branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment