New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: AAAA record validation in dnsimple_record resource #54

Merged
merged 2 commits into from Mar 21, 2018

Conversation

Projects
None yet
2 participants
@martinisoft
Member

martinisoft commented Mar 21, 2018

Found a bug in the validation for the AAAA option in the dnsimple_record resource where we missed a letter in the record type.

@martinisoft martinisoft self-assigned this Mar 21, 2018

@martinisoft martinisoft requested a review from onlyhavecans Mar 21, 2018

@martinisoft

This comment has been minimized.

Member

martinisoft commented Mar 21, 2018

I can rebase this PR after #53 is merged which should help the test suite pass.

@onlyhavecans

Great catch.

Can we have a test for this to prevent regression?

@onlyhavecans

This comment has been minimized.

Contributor

onlyhavecans commented Mar 21, 2018

That was supposed to be an approval with comment

@martinisoft martinisoft force-pushed the bugfix/quad_a_record_validation branch from 5d17364 to d9547ae Mar 21, 2018

@martinisoft martinisoft merged commit b79ba50 into master Mar 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@martinisoft martinisoft deleted the bugfix/quad_a_record_validation branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment