New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect search domains #11

Merged
merged 1 commit into from Jul 14, 2014

Conversation

Projects
None yet
5 participants
@carolinebeauchamp
Contributor

carolinebeauchamp commented Feb 24, 2014

Left company specific domains in the last pull request! Attribute-ise these...

@arr-dev

This comment has been minimized.

Show comment
Hide comment
@arr-dev

arr-dev Mar 26, 2014

This should really be released

arr-dev commented Mar 26, 2014

This should really be released

@StephenKing

This comment has been minimized.

Show comment
Hide comment
@StephenKing

StephenKing commented Jul 1, 2014

👍

@chef-supermarket

This comment has been minimized.

Show comment
Hide comment
@chef-supermarket

chef-supermarket Jul 11, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

  • @chrischillibean

Please sign the CLA here.

chef-supermarket commented Jul 11, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

  • @chrischillibean

Please sign the CLA here.

@StephenKing

This comment has been minimized.

Show comment
Hide comment
@StephenKing

StephenKing Jul 14, 2014

@chrischillibean are you going to sign the CLA? Otherwise I'd upload a similar but different patch

StephenKing commented Jul 14, 2014

@chrischillibean are you going to sign the CLA? Otherwise I'd upload a similar but different patch

@carolinebeauchamp

This comment has been minimized.

Show comment
Hide comment
@carolinebeauchamp

carolinebeauchamp Jul 14, 2014

Contributor

I do intend to get this signed, but it will have to be on behalf of my company, so it may take a while to get the right permissions from the right people.

However, the patch is pretty trivial, so I wouldn't see any problems if you wish to upload something similar - might resolve this quicker

Contributor

carolinebeauchamp commented Jul 14, 2014

I do intend to get this signed, but it will have to be on behalf of my company, so it may take a while to get the right permissions from the right people.

However, the patch is pretty trivial, so I wouldn't see any problems if you wish to upload something similar - might resolve this quicker

@chef-supermarket

This comment has been minimized.

Show comment
Hide comment
@chef-supermarket

chef-supermarket Jul 14, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

  • @chrischillibean

Please sign the CLA here.

chef-supermarket commented Jul 14, 2014

Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

The following GitHub users do not appear to have signed a CLA:

  • @chrischillibean

Please sign the CLA here.

@StephenKing

This comment has been minimized.

Show comment
Hide comment
@StephenKing

StephenKing Jul 14, 2014

@someara @sethvargo do you require a CLA for this trivial fix or can it be merged right now?

StephenKing commented Jul 14, 2014

@someara @sethvargo do you require a CLA for this trivial fix or can it be merged right now?

someara pushed a commit that referenced this pull request Jul 14, 2014

Sean OMeara
Merge pull request #11 from chrischillibean/master
Remove incorrect search domains

@someara someara merged commit 2ac6eba into dnsimple:master Jul 14, 2014

@someara

This comment has been minimized.

Show comment
Hide comment
@someara

someara Jul 14, 2014

Contributor

I'd say that qualifies at trivial =)
Merged.

Contributor

someara commented Jul 14, 2014

I'd say that qualifies at trivial =)
Merged.

@StephenKing

This comment has been minimized.

Show comment
Hide comment
@StephenKing

StephenKing commented Jul 14, 2014

Thanks!
/cc @andristeiner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment