New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, bug fixes and small improvements. #30

Merged
merged 11 commits into from Dec 23, 2015

Conversation

Projects
None yet
2 participants
@therobot
Contributor

therobot commented Dec 22, 2015

This PR addresses several small details that were forgotten in 1.1.0.

  • It brings back the code that creates the database schema and database user grants (for postgres).
  • Fixes a bug with setting the source URL when compiling due to not using lazy evaluation.
  • General cleanup and updating to Chef 12.5 in kitchen.yml
  • Small documentation improvements.

Bringing back the user creating and schema load code allows better testing since there is a completely working pdns instance with postgres backend.

therobot added some commits Dec 17, 2015

Deprecated
Until the sqlite3 backend is brought back
Adding dependency
database cookbook is required to load the schemas
and create users/dbs for source recipes when
testing.
Cleanup
Also, using latest Chef 12
Improving README
Adding a #TODO sectiom
Adding a note on DB settings when using packages
and database backends
Adding grants for pdns user
And handling the way the grants are executed in chef
@martinisoft

This comment has been minimized.

Show comment
Hide comment
@martinisoft

martinisoft Dec 22, 2015

Member

This looks good to me 👍

Think I'll try to get this cookbook testing on Travis so we have some CI coverage checking on PRs as a sanity check.

Member

martinisoft commented Dec 22, 2015

This looks good to me 👍

Think I'll try to get this cookbook testing on Travis so we have some CI coverage checking on PRs as a sanity check.

@therobot

This comment has been minimized.

Show comment
Hide comment
@therobot

therobot Dec 22, 2015

Contributor

There is still something not working in this PR.

I can't confirm if it is because the custom LWRP of the database cookbook, but the following lines are not executed:

postgresql_database 'powerdns_grant' do
  connection postgresql_connection_info
  sql "GRANT ALL ON ALL TABLES IN SCHEMA public TO pdns;"
  action :nothing
end

I still need to figure out another way of this piece of code just executing once in order to make it work. Once there I'll 🚢

Contributor

therobot commented Dec 22, 2015

There is still something not working in this PR.

I can't confirm if it is because the custom LWRP of the database cookbook, but the following lines are not executed:

postgresql_database 'powerdns_grant' do
  connection postgresql_connection_info
  sql "GRANT ALL ON ALL TABLES IN SCHEMA public TO pdns;"
  action :nothing
end

I still need to figure out another way of this piece of code just executing once in order to make it work. Once there I'll 🚢

therobot added a commit that referenced this pull request Dec 23, 2015

Merge pull request #30 from aetrion/creating_schema_and_grants
Cleanup, bug fixes and small improvements.

@therobot therobot merged commit 031d4dd into master Dec 23, 2015

@therobot therobot deleted the creating_schema_and_grants branch Dec 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment