Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing dependency libssl dev on source install #45

Merged
merged 3 commits into from Feb 8, 2017

Conversation

Projects
None yet
2 participants
@therobot
Copy link
Contributor

commented Feb 8, 2017

This PR addreses #44 and it installs the missing library.

It additionally adds Vagrantfile.erb since test kitchen complained that it was missing.

@martinisoft
Copy link
Contributor

left a comment

Think one file might have been added by mistake

@@ -0,0 +1,133 @@
<% config[:vagrantfiles].each do |vagrantfile| %>

This comment has been minimized.

Copy link
@martinisoft

martinisoft Feb 8, 2017

Contributor

Why do we need this vagrant template?

This comment has been minimized.

Copy link
@therobot

therobot Feb 8, 2017

Author Contributor

It's explained on the PR @martinisoft:

test kitchen complained that it was missing.

I was unable to run integration tests without adding a vagrantfile, but I could not also find any reference to it. I have uninstalled any vagrant plugins in case it was that, but still had the problem.

This comment has been minimized.

Copy link
@martinisoft

martinisoft Feb 8, 2017

Contributor

@therobot You might have a global kitchen file in your ~/.kitchen/config.yml that might be referencing it.

This comment has been minimized.

Copy link
@therobot

therobot Feb 8, 2017

Author Contributor

I reviewed that case too, but it was not there, I just found it here: .kitchen.local.yml

This comment has been minimized.

Copy link
@martinisoft

martinisoft Feb 8, 2017

Contributor

@therobot That isn't tracked in git (it's ignored local kitchen configs) so I'd just add Vagrantfile.erb to the gitignore in this commit to resolve that.

This comment has been minimized.

Copy link
@therobot

therobot Feb 8, 2017

Author Contributor

I deleted both Vagrantfile.erb and .kitchen.local.yml I don't think I need it @martinisoft

@therobot therobot merged commit e19022a into master Feb 8, 2017

@therobot therobot deleted the bugfix/missing-dependency-libssl-dev branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.