Add systemd support for recursor and authoritative PowerDNS #66
Hello @therobot, I have a time out issue, is that possible to increase the concurrency for the jobs: (ref: https://docs.travis-ci.com/user/customizing-the-build#Build-Timeouts) ?
therobot left a comment
Hello @jmauro thanks a lot for your work. I just reviewed this PR and still needs some hammering in order to be merged.
Apart from all the comments in the reviews, unit test don't pass on my local machine.
Also am of the opinion that both authoritative resources and helpers and recursor resources and helpers should match each other as much as possible in terms of style, and concept. This will explain some of the comments here (consistency).
@therobot, regarding the unit test, personally, I don't have any issue chefspec and all kitchen-dokken test passed on my branch. What kind of error have you?
For the consistency issue you are mentionnig, do you want me to be as close as possible from one function to the other? Same type of function name and so one? That's fine by me, just tell what name schema you want.
@jmauro thanks for your work on making the test pass, it looks great :)
I still have a few comments, specially regarding the implementation of the
Once we have this sorted out, and the question sorted we're ready to merge.
I changed back the
10 times, most recently
Jun 16, 2017
Hello @therobot ,