Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rake tasks #72

Merged
merged 3 commits into from Jun 27, 2017

Conversation

Projects
None yet
3 participants
@jmauro
Copy link
Contributor

commented Jun 16, 2017

STATE:
Currently, the kitchen-test are not run in parallel

FIX:

  • Split the rake file into differents pieces
  • Add concurrency for kitchen test

Change-Id: Ic6cf762f4bda29df412a5e670ad4406872fe47bf

@jmauro jmauro force-pushed the criteo-forks:rakelib branch 5 times, most recently from 0a1ef91 to 5f32fd4 Jun 16, 2017

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

Hello @therobot,

All suite are active and the entire build takes 18 mins, isn't that great?

@therobot

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2017

@jmauro thanks for your contribution.

I find difficult to understand the sentence: 'isn't that create', can you elaborate?

Thanks.

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

'great' better?

@jmauro jmauro force-pushed the criteo-forks:rakelib branch from 5f32fd4 to adacfda Jun 16, 2017

@therobot

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2017

Ah, thanks, yes!, it's great to have an 18 mins build. Let me check if I can merge this PR now.

@therobot
Copy link
Contributor

left a comment

LGTM

@therobot

This comment has been minimized.

Copy link
Contributor

commented Jun 16, 2017

But build has failed.

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

Yes I tried what @someara told me (Bumping to 2.2.3)

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

Reverting back to an old version of kitchen-dokken

@jmauro jmauro force-pushed the criteo-forks:rakelib branch 13 times, most recently from 03419c3 to 50bba46 Jun 16, 2017

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

Finally, test seem stable. Launch them twice to make sure there were no inspec bug.

@therobot any chance this will be merged soon?

@jmauro jmauro referenced this pull request Jun 16, 2017

Closed

Recursor pkg resource #73

@jmauro jmauro force-pushed the criteo-forks:rakelib branch from 50bba46 to c3b7a23 Jun 17, 2017

@jmauro jmauro force-pushed the criteo-forks:rakelib branch 8 times, most recently from c2d4c86 to 172f81b Jun 17, 2017

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2017

Hello,

Finally, I used the matrix feature to split test by function and also add a concurrency setting.

@martinisoft martinisoft requested review from martinisoft and onlyhavecans Jun 21, 2017

@onlyhavecans
Copy link
Contributor

left a comment

What's the advantage of breaking up the rake like this?
Also why not leave the tasks all in the main rakefile so they are easily locatable.
I'm not against this but I don't understand the advantage either.

I do think duplicating the tasks across the files seems like a problem though

).join(' ')
end
end
task unit: %w( unit:chefspec )

This comment has been minimized.

Copy link
@onlyhavecans

onlyhavecans Jun 22, 2017

Contributor

Why duplicate this code both here and in 99-rake-tasks?

This comment has been minimized.

Copy link
@jmauro

jmauro Jun 22, 2017

Author Contributor

Fixed

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

@onlyhavecans splitting the rakefile is just to break thing down, better isolation and avoiding reading a huge rakefile for just changing for instance a rubucop rules, but maybe you are right this could be overkill.

let me know if you want me to merge them back, I just find that easier to read.

Regards,
JM

@jmauro jmauro force-pushed the criteo-forks:rakelib branch from 172f81b to 4491a91 Jun 22, 2017

@onlyhavecans

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2017

I'm Ok with it split up. My only "change request" was the duplicated code.

@jmauro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

The fix was provided :D.

end
end

task style: %w( style:rubocop style:foodcritic )

This comment has been minimized.

Copy link
@onlyhavecans

onlyhavecans Jun 22, 2017

Contributor

Sorry, this is also duplicate code

This comment has been minimized.

Copy link
@jmauro

jmauro Jun 22, 2017

Author Contributor

good catch ;)

This comment has been minimized.

Copy link
@jmauro

jmauro Jun 22, 2017

Author Contributor

Fix on its way.

@jmauro jmauro force-pushed the criteo-forks:rakelib branch from 4491a91 to 734a9a1 Jun 22, 2017

@jmauro jmauro force-pushed the criteo-forks:rakelib branch 3 times, most recently from 2f87f48 to eb0008b Jun 23, 2017

jmauro added some commits Jun 16, 2017

Change Rake tasks
STATE:
Currently, the kitchen-test are not run in parallel and the
Dokken-network interface is not working properly with travis

FIX:
- Split the rake file into differents pieces
- Create a travis matrix to split kitchen tests by function with a
  specific concurrency setting (inspired by "kitchen in travis", Ref:
  https://github.com/zuazo/kitchen-in-travis#test-multiple-versions-of-chef)
- Most of the concurrency are low because of inspec bug (Ref:
  inspec/inspec#1598)
- Set the kitchen-dokken version <= 2.1.10 (Ref:
  someara/kitchen-dokken#112)

Change-Id: Ic6cf762f4bda29df412a5e670ad4406872fe47bf
Fix the inspec test for the pdns 4.0.4
Change-Id: I863968e040bd8ca5d7ffef8bec6adeab56601a63

@jmauro jmauro force-pushed the criteo-forks:rakelib branch from eb0008b to 9205579 Jun 26, 2017

@therobot therobot merged commit 99f766b into dnsimple:master Jun 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jmauro jmauro deleted the criteo-forks:rakelib branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.