From 7904faa2a4983ec1b076b9f41cb68b3bad7c7945 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 25 Mar 2021 12:15:44 +0000 Subject: [PATCH 1/3] Update rubocop requirement from 1.11.0 to 1.12.0 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.11.0...v1.12.0) Signed-off-by: dependabot-preview[bot] --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index ebb09868..65c4eadc 100644 --- a/Gemfile +++ b/Gemfile @@ -5,7 +5,7 @@ source 'https://rubygems.org' gemspec gem 'coveralls', require: false -gem 'rubocop', '1.11.0', require: false +gem 'rubocop', '1.12.0', require: false gem 'rubocop-performance', require: false gem 'rubocop-rake', require: false gem 'rubocop-rspec', require: false From ddbcf416fc7182cf1f192d6d7f30eccb5bf30676 Mon Sep 17 00:00:00 2001 From: Santiago Traversa Date: Mon, 29 Mar 2021 08:45:29 -0300 Subject: [PATCH 2/3] Update .rubocop_todo.yml --- .rubocop_todo.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 71e1aeee..3bf2d0ed 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,17 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2021-02-11 05:02:06 UTC using RuboCop version 1.9.1. +# on 2021-03-29 11:45:17 UTC using RuboCop version 1.12.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -# Cop supports --auto-correct. -Lint/RedundantDirGlobSort: - Exclude: - - 'spec/spec_helper.rb' - # Offense count: 6 # Configuration parameters: Prefixes. # Prefixes: when, with, without @@ -78,5 +72,6 @@ RSpec/VerifiedDoubles: - 'spec/dnsimple/client_spec.rb' # Offense count: 39 +# Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false From c9d24fe9931512b88e1e25631161777fb78efcb3 Mon Sep 17 00:00:00 2001 From: Santiago Traversa Date: Mon, 29 Mar 2021 08:49:34 -0300 Subject: [PATCH 3/3] [RSpec/RepeatedDescription] Don't repeat descriptions within an example group As there was a typo in a spec title --- .rubocop_todo.yml | 7 +------ spec/dnsimple/client/zones_spec.rb | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3bf2d0ed..20fc0ed5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2021-03-29 11:45:17 UTC using RuboCop version 1.12.0. +# on 2021-03-29 11:48:18 UTC using RuboCop version 1.12.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -39,11 +39,6 @@ RSpec/MultipleExpectations: RSpec/NamedSubject: Enabled: false -# Offense count: 2 -RSpec/RepeatedDescription: - Exclude: - - 'spec/dnsimple/client/zones_spec.rb' - # Offense count: 10 RSpec/StubbedMock: Exclude: diff --git a/spec/dnsimple/client/zones_spec.rb b/spec/dnsimple/client/zones_spec.rb index 787746d1..61c3a6b5 100644 --- a/spec/dnsimple/client/zones_spec.rb +++ b/spec/dnsimple/client/zones_spec.rb @@ -89,7 +89,7 @@ expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&sort=name:desc") end - it "supports sorting" do + it "supports filtering" do subject.all_zones(account_id, filter: { name_like: "zone.test" }) expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&name_like=zone.test")