Remove extra aliases (#168)

Closes GH-114. This change makes the library
more consistent with other implementations.

lib/dnsimple/client/accounts.rb

@@ -18,7 +18,6 @@ def accounts(options = {})
 
         Dnsimple::Response.new(response, response["data"].map { |r| Struct::Account.new(r) })
       end
-      alias list accounts
       alias list_accounts accounts
 
     end

lib/dnsimple/client/certificates.rb

@@ -29,6 +29,7 @@ def certificates(account_id, domain_name, options = {})
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::Certificate.new(r) })
       end
+      alias list_certificates certificates
 
       # List ALL the certificates for the domain in the account.
       #

lib/dnsimple/client/contacts.rb

@@ -29,7 +29,6 @@ def contacts(account_id, options = {})
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::Contact.new(r) })
       end
-      alias list contacts
       alias list_contacts contacts
 
       # Lists ALL the contacts in the account.
@@ -54,7 +53,6 @@ def contacts(account_id, options = {})
       def all_contacts(account_id, options = {})
         paginate(:contacts, account_id, options)
       end
-      alias all all_contacts
 
       # Creates a contact in the account.
       #
@@ -72,7 +70,6 @@ def create_contact(account_id, attributes, options = {})
 
         Dnsimple::Response.new(response, Struct::Contact.new(response["data"]))
       end
-      alias create create_contact
 
       # Gets a contact from the account.
       #
@@ -107,7 +104,6 @@ def update_contact(account_id, contact_id, attributes, options = {})
 
         Dnsimple::Response.new(response, Struct::Contact.new(response["data"]))
       end
-      alias update update_contact
 
       # Deletes a contact from the account.
       #
@@ -127,7 +123,6 @@ def delete_contact(account_id, contact_id, options = {})
 
         Dnsimple::Response.new(response, nil)
       end
-      alias delete delete_contact
 
     end
   end

lib/dnsimple/client/domains.rb

@@ -33,7 +33,6 @@ def domains(account_id, options = {})
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::Domain.new(r) })
       end
-      alias list domains
       alias list_domains domains
 
       # Lists ALL the domains in the account.
@@ -59,7 +58,6 @@ def domains(account_id, options = {})
       def all_domains(account_id, options = {})
         paginate(:domains, account_id, options)
       end
-      alias all all_domains
 
       # Creates a domain in the account.
       #
@@ -78,7 +76,6 @@ def create_domain(account_id, attributes, options = {})
 
         Dnsimple::Response.new(response, Struct::Domain.new(response["data"]))
       end
-      alias create create_domain
 
       # Gets a domain from the account.
       #
@@ -115,7 +112,6 @@ def delete_domain(account_id, domain_id, options = {})
 
         Dnsimple::Response.new(response, nil)
       end
-      alias delete delete_domain
 
       # Resets the domain token.
       #

lib/dnsimple/client/services.rb

@@ -28,7 +28,6 @@ def services(options = {})
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::Service.new(r) })
       end
-      alias list services
       alias list_services services
 
       # Lists ALL the available one-click services.
@@ -55,7 +54,6 @@ def services(options = {})
       def all_services(options = {})
         paginate(:services, options)
       end
-      alias all all_services
 
       # Gets the service with specified ID.
       #

lib/dnsimple/client/webhooks.rb

@@ -28,7 +28,6 @@ def webhooks(account_id, options = {})
 
         Dnsimple::CollectionResponse.new(response, response["data"].map { |r| Struct::Webhook.new(r) })
       end
-      alias list webhooks
       alias list_webhooks webhooks
 
       # Creates a webhook in the account.
@@ -47,7 +46,6 @@ def create_webhook(account_id, attributes, options = {})
 
         Dnsimple::Response.new(response, Struct::Webhook.new(response["data"]))
       end
-      alias create create_webhook
 
       # Gets a webhook from the account.
       #
@@ -84,7 +82,6 @@ def delete_webhook(account_id, webhook_id, options = {})
 
         Dnsimple::Response.new(response, nil)
       end
-      alias delete delete_webhook
 
     end
   end

lib/dnsimple/client/zones.rb

@@ -33,7 +33,6 @@ def zones(account_id, options = {})
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::Zone.new(r) })
       end
-      alias list zones
       alias list_zones zones
 
       # Lists ALL the zones in the account.

lib/dnsimple/client/zones_records.rb

@@ -30,11 +30,12 @@ module ZonesRecords
       #
       # @raise  [Dnsimple::NotFoundError]
       # @raise  [Dnsimple::RequestError]
-      def list_zone_records(account_id, zone_id, options = {})
+      def zone_records(account_id, zone_id, options = {})
         response = client.get(Client.versioned("/%s/zones/%s/records" % [account_id, zone_id]), Options::ListOptions.new(options))
 
         Dnsimple::PaginatedResponse.new(response, response["data"].map { |r| Struct::ZoneRecord.new(r) })
       end
+      alias list_zone_records zone_records
 
       # Lists ALL the zone records in the account.
       #

spec/dnsimple/client_spec.rb

@@ -130,7 +130,7 @@
               format: :json,
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
-          )
+            )
           .and_return(double('response', code: 200))
 
       subject.request(:get, 'foo')
@@ -145,7 +145,7 @@
               query: { foo: "bar" },
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT, "Custom" => "Header" }
-          )
+            )
           .and_return(double('response', code: 200))
 
       subject.request(:put, 'foo', { something: "else" }, { query: { foo: "bar" }, headers: { "Custom" => "Header" } })
@@ -159,7 +159,7 @@
               body: { something: "else" },
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => Dnsimple::Default::USER_AGENT }
-          )
+            )
           .and_return(double('response', code: 200))
 
       subject.request(:post, 'foo', { something: "else" }, { headers: { "Content-Type" => "application/x-www-form-urlencoded" } })
@@ -173,7 +173,7 @@
               http_proxyaddr: "example-proxy.com",
               http_proxyport: "4321",
               headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
-          )
+            )
           .and_return(double('response', code: 200))
 
       subject = described_class.new(proxy: "example-proxy.com:4321")
@@ -186,7 +186,7 @@
               "#{subject.base_url}test",
               format: :json,
               headers: hash_including("User-Agent" => "#{Dnsimple::Default::USER_AGENT} customAgent")
-          )
+            )
           .and_return(double("response", code: 200))
 
       subject = described_class.new(user_agent: "customAgent")