You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.rubocop_dnsimple.yml: Style/PredicateName has the wrong namespace - should be Naming
Inspecting 98 files
.W..........................C....................W.W.....W........................................
Offenses:
Rakefile:27:19: W: Avoid rescuing without specifying an error class.
rm_r "yardoc" rescue nil
^^^^^^
lib/dnsimple/client.rb:64:25: C: Use each_key instead of keys.each.
Dnsimple::Default.keys.each do |key|
^^^^^^^^^
lib/dnsimple/struct/extended_attribute.rb:34:7: W: Method Dnsimple::Struct::ExtendedAttribute#options= is defined at both lib/dnsimple/struct/extended_attribute.rb:27 and lib/dnsimple/struct/extended_attribute.rb:34.
def options=(opts)
^^^
lib/dnsimple/struct/service.rb:55:7: W: Method Dnsimple::Struct::Service#settings= is defined at both lib/dnsimple/struct/service.rb:48 and lib/dnsimple/struct/service.rb:55.
def settings=(settings)
^^^
lib/dnsimple/struct/whoami.rb:16:7: W: Method Dnsimple::Struct::Whoami#account= is defined at both lib/dnsimple/struct/whoami.rb:6 and lib/dnsimple/struct/whoami.rb:16.
def account=(account)
^^^
lib/dnsimple/struct/whoami.rb:24:7: W: Method Dnsimple::Struct::Whoami#user= is defined at both lib/dnsimple/struct/whoami.rb:9 and lib/dnsimple/struct/whoami.rb:24.
def user=(user)
^^^
The text was updated successfully, but these errors were encountered:
I think method already defined warnings can be fixed by changing the attribute from attr_accessor to attr_reader since there is customized writer declared for them.
For each_key, rubocop warning should probably figure out that Dnsimple::Default is a module, just because Dnsimple::Default respond to [keys]https://github.com/dnsimple/dnsimple-ruby/blob/master/lib/dnsimple/default.rb#L16) method, it doesn't has to be a hash 😄
The text was updated successfully, but these errors were encountered: