Improve logging

pom.xml

@@ -205,7 +205,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-api</artifactId>
-            <version>1.7.28</version>
+            <version>1.7.29</version>
         </dependency>
         <dependency>
             <groupId>org.projectlombok</groupId>
@@ -249,6 +249,12 @@
             <version>3.1.0</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-simple</artifactId>
+            <version>1.7.29</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <profiles>

src/main/java/org/xbill/DNS/Cache.java

@@ -721,8 +721,9 @@ public SetResponse addMessage(Message in) {
       cred = getCred(Section.ADDITIONAL, isAuth);
       addRRset(rRset, cred);
     }
-    log.debug("addMessage: {}", response);
-    return (response);
+
+    log.debug("caching {} for {}", response, in.getQuestion().getName());
+    return response;
   }
 
   /**

src/main/java/org/xbill/DNS/ExtendedResolver.java

@@ -428,4 +428,9 @@ public void setLoadBalance(boolean flag) {
   public void setRetries(int retries) {
     this.retries = retries;
   }
+
+  @Override
+  public String toString() {
+    return "ExtendedResolver of " + resolvers;
+  }
 }

src/main/java/org/xbill/DNS/Lookup.java

@@ -433,10 +433,8 @@ private void processResponse(Name name, SetResponse response) {
 
   private void lookup(Name current) {
     SetResponse sr = cache.lookupRecords(current, type, credibility);
-    if (log.isDebugEnabled()) {
-      log.debug("lookup {} {}", current, Type.string(type));
-      log.debug(sr.toString());
-    }
+    log.debug("lookup {} {}, cache answer: {}", current, Type.string(type), sr);
+
     processResponse(current, sr);
     if (done || doneCurrent) {
       return;
@@ -448,7 +446,7 @@ private void lookup(Name current) {
     try {
       response = resolver.send(query);
     } catch (IOException e) {
-      log.debug("Lookup failed", e);
+      log.debug("Lookup failed using resolver {}", resolver, e);
 
       // A network error occurred.  Press on.
       if (e instanceof InterruptedIOException) {
@@ -478,10 +476,8 @@ private void lookup(Name current) {
     if (sr == null) {
       sr = cache.lookupRecords(current, type, credibility);
     }
-    if (log.isDebugEnabled()) {
-      log.debug("queried {} {}", current, Type.string(type));
-      log.debug(sr.toString());
-    }
+
+    log.debug("Queried {} {}: {}", current, Type.string(type), sr);
     processResponse(current, sr);
   }
 

src/main/java/org/xbill/DNS/SimpleResolver.java

@@ -344,4 +344,9 @@ private Message sendAXFR(Message query) throws IOException {
     }
     return response;
   }
+
+  @Override
+  public String toString() {
+    return "SimpleResolver [" + address + "]";
+  }
 }

src/test/resources/simplelogger.properties

@@ -0,0 +1 @@
+org.slf4j.simpleLogger.defaultLogLevel=debug