Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restoring active position on byte buffers #184

Merged
merged 1 commit into from Apr 5, 2021
Merged

Fix restoring active position on byte buffers #184

merged 1 commit into from Apr 5, 2021

Conversation

ryru
Copy link
Contributor

@ryru ryru commented Apr 5, 2021

Wrong restored position lead to incomplete EDNS0 options parsing.

nresare
nresare approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@nresare nresare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, and thank you for adding the tests.

@nresare
Copy link
Member

nresare commented Apr 5, 2021

Would you mind reformatting the tests with mvn com.coveo:fmt-maven-plugin:format? In this case the output turns out significantly worse looking than what you wrote, but I think it is a small price to pay to not spend a lot of time discussing formatting differences etc.

@ryru
Fix restoring active position on byte buffers
a787f12 
Wrong restored position lead to incomplete EDNS0 options parsing.
@ryru
Copy link
Contributor Author

ryru commented Apr 5, 2021

Patch is now formatted according mvn com.coveo:fmt-maven-plugin:format. What about the time out issue NioTcpClientTest.testResponseStream:79 timed out waiting for messages in CI?

@nresare
Copy link
Member

nresare commented Apr 5, 2021

I don't know what is happening with the failing tests. Tests run successfully locally here (macOS 11, Java 11) Maybe @ibauersachs knows?

@ibauersachs
Copy link
Member

I don't know why they failed, rerun was successful, so I assume some spurious event on a GHA runner.

@ibauersachs ibauersachs merged commit bd37aea into dnsjava:master Apr 5, 2021
@ibauersachs ibauersachs added this to the 3.4 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nresare nresare nresare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryru @nresare @ibauersachs