Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Lists for RRset #56
@bwelling Right, seems it was a little late when I wrote that. The type-bitmap in RRSIGs must have confused me. The lists aren't copied again, that is already being done in the existing private rrs(boolean, boolean) to split data from sigs. There could be two separate internal Lists to make this unnecessary in the non-cycling case.
I'm not sure why the rrs and sigs lists are separate. It's possible that it was a misguided optimization, but it would definitely make sense to split them.
The optional cycling is there because iterating through records in a nondeterministic order is often useful, so it seemed reasonable to make it part of the RRset iteration. If I was designing the API from scratch, I'm not sure if it would still make sense or not (it should be somewhere, but that might njot be the right place), and I definitely wouldn't implement the existing cyclic behavior that requires a write lock to maintain the position counter.