Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling $INCLUDE #67

Merged
merged 2 commits into from Jul 14, 2019

Conversation

@jdreed
Copy link
Contributor

commented Jul 9, 2019

  • Add support for disabling $INCLUDE when parsing master files
  • Optionally throw an exception (for bubbling up) when $INCLUDE processing is disabled, and the token is encountered
Add support for disabling $INCLUDE
  - Add support for disabling $INCLUDE when parsing master files
*/
public void
disableIncludes() {
noExpandIncludes = true;

This comment has been minimized.

Copy link
@ibauersachs

ibauersachs Jul 14, 2019

Member

Please call the overload instead of directly assigning variables: disableIncludes(false)

This comment has been minimized.

Copy link
@jdreed

jdreed Jul 14, 2019

Author Contributor

Updated with d9944b2. What is this project's preferred workflow? rebase and re-push to my branch? Or keep both commits?

This comment has been minimized.

Copy link
@ibauersachs

ibauersachs Jul 14, 2019

Member

Doesn't really matter to me. I often squash PRs during merge if there's no relevant history.

disableIncludes(): call overload
  - Don't assign to the variables directly

@ibauersachs ibauersachs merged commit 0f36a98 into dnsjava:master Jul 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+6.4%) to 53.034%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.