Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nameserver lookup to an SPI interface #82

Merged
merged 7 commits into from Nov 30, 2019
Merged

Conversation

@ibauersachs
Copy link
Member

ibauersachs commented Nov 4, 2019

Closes #6, #8, #55, #57, #68, #80

Closes #6, #8, #55, #57, #80
@ibauersachs ibauersachs requested a review from kingle Nov 4, 2019
* context to operate on which must be set by calling {@link #setContext(Object)}.
*
* <p>If you are developing for Android, consider implementing your own {@link
* ResolverConfigProvider} that listens to network callbacks and properly refreshes on link changes.

This comment has been minimized.

Copy link
@camhart

camhart Nov 8, 2019

Can you define "link changes" further? Does that just mean network changes?

This comment has been minimized.

Copy link
@ibauersachs

ibauersachs Nov 8, 2019

Author Member

Yes, I'm not developing for Android, so I can only assume things from reading the docs. ConnectivityManager.registerNetworkCallback and registerDefaultNetworkCallback seem to be interesting APIs.

@ibauersachs ibauersachs force-pushed the resolver-spi branch 8 times, most recently from 39f40fc to e23a363 Nov 9, 2019
@ibauersachs ibauersachs force-pushed the resolver-spi branch from e23a363 to cb30bfa Nov 10, 2019
@ibauersachs ibauersachs merged commit 8753154 into master Nov 30, 2019
10 checks passed
10 checks passed
Java 1.8/x64/ubuntu-16.04
Details
Java 11/x64/ubuntu-16.04
Details
Java 1.8/x64/ubuntu-latest
Details
Java 11/x64/ubuntu-latest
Details
Java 1.8/x86/windows-latest
Details
Java 1.8/x64/windows-latest
Details
Java 11/x86/windows-latest
Details
Java 11/x64/windows-latest
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 50.379%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.