Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modal for showing errors #125

merged 2 commits into from Nov 6, 2019


Copy link

MattIPv4 commented Nov 6, 2019

Type of Change

  • Shared Source: New template & i18n data
  • Tool Source: DNS & SPF

What issue does this relate to?

Resolves #124

What should this PR do?

Removes the usage of alert() and instead uses a custom error modal which extends the do-vue/templates/Modal component.

What are the acceptance criteria?

  • On both tools, the following:
    • Searching an invalid domain from the splash screen shows the modal
      • The modal can be closed as expected
    • Searching an invalid domain from the main view shows the modal
      • The modal can be closed as expected



This comment has been minimized.

Copy link

github-actions bot commented on 7ca2f26 Nov 6, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
@MattIPv4 MattIPv4 requested a review from JakeMakesStuff Nov 6, 2019
@MattIPv4 MattIPv4 merged commit f1eecfe into master Nov 6, 2019
1 check passed
1 check passed
build build
@MattIPv4 MattIPv4 deleted the error-modal branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.