Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show validation error/comment from Cloudflare #126

Merged
merged 3 commits into from Nov 6, 2019

Conversation

@MattIPv4
Copy link
Member

MattIPv4 commented Nov 6, 2019

Type of Change

  • Shared Source: New validateDomain util
  • Tool Source: DNS & SPF

What issue does this relate to?

Resolves #123

What should this PR do?

Shows the Comment that Cloudflare provides when the domain validation lookup fails. A good example of this is a domain that exists but fails DNSSEC validation, such as dnssec-failed.org.

What are the acceptance criteria?

  • Both tools validate domains correctly
  • If a bad DNSSEC domain is entered, the comment from Cloudflare will show
    • Can be tested with dnssec-failed.org

image

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on c2d0929 Nov 6, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
@MattIPv4

This comment has been minimized.

Copy link
Member Author

MattIPv4 commented Nov 6, 2019

@JakeMakesStuff @ruf-io - Do we want to prefix the Cloudflare comment to make it clear that the message is from Cloudflare and not us, or are we happy just displaying it in the modal as it is currently?

@MattIPv4

This comment has been minimized.

Copy link
Member Author

MattIPv4 commented Nov 6, 2019

@JakeMakesStuff - I don't think there's really an easy way to detect the link in this string comment and render the external link component for it, is there?

@JakeMakesStuff

This comment has been minimized.

Copy link
Member

JakeMakesStuff commented Nov 6, 2019

@MattIPv4 A way we could do that is to make a "URL" data type and then make a string | URL array. Then we could for loop through all of the things and if it's a string print it and if not wrap it in the link object.

src/spf-explainer/i18n/en/templates/app.ts Outdated Show resolved Hide resolved
src/shared/utils/validateDomain.ts Outdated Show resolved Hide resolved
@MattIPv4

This comment has been minimized.

Copy link
Member Author

MattIPv4 commented Nov 6, 2019

@JakeMakesStuff We can look at doing that in a different PR later on then :)

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on d593568 Nov 6, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
@MattIPv4 MattIPv4 requested a review from JakeMakesStuff Nov 6, 2019
Copy link
Member

JakeMakesStuff left a comment

Lgtm.

@JakeMakesStuff JakeMakesStuff merged commit 1a3a44c into master Nov 6, 2019
1 check passed
1 check passed
build build
Details
@MattIPv4 MattIPv4 deleted the show-validation-error branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.