Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL updates #133

Merged
merged 4 commits into from Jan 7, 2020
Merged

QOL updates #133

merged 4 commits into from Jan 7, 2020

Conversation

@JakeMakesStuff
Copy link
Member

JakeMakesStuff commented Jan 6, 2020

Type of Change

  • Build Scripts: Building/testing
  • Tool Source: DNS tool

What issue does this relate to?

Fixes #132

What should this PR do?

  • Fixes URL anchors (The issue was that the reference doesn't exist. If we spawn it but hide it on initial load, we fix the bug)
  • Fixes the dev env by upgrading do-vue.
  • Upgrade other packages while we're at it.
  • Fix some linting issues.

What are the acceptance criteria?

Does it fix the bug?

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 94b9fa9 Jan 6, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 6a816f9 Jan 6, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
The issue was that the reference doesn't exist. If we spawn it but hide it on initial load, we fix the bug.
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on cc0022b Jan 6, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

dns-lookup spf-explainer
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Jan 6, 2020
Copy link
Member

MattIPv4 left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit 0e2d50b into master Jan 7, 2020
1 check passed
1 check passed
build
Details
@MattIPv4 MattIPv4 deleted the qol-updates branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.