Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the repo and emphasise the license (Fixes #39) #44

Merged
merged 5 commits into from Aug 6, 2019

Conversation

@JakeMakesStuff
Copy link
Member

commented Aug 6, 2019

No description provided.

@JakeMakesStuff JakeMakesStuff changed the title Add a link to the repo and enphasise the license (Fixes #39) Add a link to the repo and emphasise the license (Fixes #39) Aug 6, 2019

@MattIPv4
Copy link
Member

left a comment

I feel this is just adding bulk to the header.

I wonder if instead we should use a GitHub corner badge and then out this current sentence into the footer?

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Aug 6, 2019

JakeMakesStuff added some commits Aug 6, 2019

src/templates/app.vue Outdated Show resolved Hide resolved
src/templates/gh_link.vue Outdated Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Aug 6, 2019

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@JakeMakesStuff As this is a visual change, could you provide before & after screenshots please?

@JakeMakesStuff

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Before:

beforetop
beforebottom

After:

aftertop
afterbottom

@JakeMakesStuff

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

@MattIPv4 Added the screenshots to the issue.

@MattIPv4
Copy link
Member

left a comment

Lgtm. Squash & merge.

@MattIPv4 MattIPv4 merged commit 5594339 into master Aug 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MattIPv4 MattIPv4 deleted the gh_repo_callout branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.