Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user if Google DNS is reporting different values (Fixes #28) #46

Merged
merged 18 commits into from Aug 8, 2019

Conversation

@JakeMakesStuff
Copy link
Member

commented Aug 7, 2019

NOTE: This is based on the locale files branch. This is because it is going to be reviewed soon anyway, so it makes more sense to base it off that and just merge that in first than to deal with merge conflicts.

JakeMakesStuff added some commits Jul 29, 2019

@MattIPv4
Copy link
Member

left a comment

Cleanup, please. Rebase against master, resolve conflicts, clean commit history.

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Aug 8, 2019

JakeMakesStuff added some commits Aug 8, 2019

@MattIPv4
Copy link
Member

left a comment

Lgtm. Squash & merge.

@MattIPv4 MattIPv4 merged commit f14dc1b into master Aug 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MattIPv4 MattIPv4 deleted the dns_differences branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.