Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explainer for TTL in each record table #49

Merged
merged 3 commits into from Aug 9, 2019

Conversation

@MattIPv4
Copy link
Member

commented Aug 9, 2019

This pull request implements a new data structure that allows for help icons to be shown next to record table headers (keys).

This is used currently to display the TTL explainer message only.

Fixes #47

image

@MattIPv4 MattIPv4 requested a review from JakeMakesStuff Aug 9, 2019

@MattIPv4 MattIPv4 self-assigned this Aug 9, 2019

@MattIPv4 MattIPv4 force-pushed the MattIPv4/explain-ttl branch from ceaed93 to 1f5bcf1 Aug 9, 2019

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Rebased onto lastest master.

@JakeMakesStuff
Copy link
Member

left a comment

Looks great to me. I like the information icon.

@JakeMakesStuff JakeMakesStuff merged commit f43676a into master Aug 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JakeMakesStuff JakeMakesStuff deleted the MattIPv4/explain-ttl branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.