Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSHFP/TLSA support #73

Merged
merged 11 commits into from Sep 3, 2019

Conversation

@JakeMakesStuff
Copy link
Member

commented Sep 2, 2019

This is awaiting a response from Cloudflare regarding issues with TLSA records (and then testing of said records).

Fixes: #53

@JakeMakesStuff JakeMakesStuff changed the title WIP: Add SSHFP/TLSA support (Fixes #53) WIP: Add SSHFP/TLSA support Sep 2, 2019

@JakeMakesStuff JakeMakesStuff changed the title WIP: Add SSHFP/TLSA support Add SSHFP/TLSA support Sep 2, 2019

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 2, 2019

src/i18n/en/templates/records.ts Outdated Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 2, 2019

@MattIPv4
Copy link
Member

left a comment

Code review. Will do a functional review once these changes are made. 👍

src/i18n/en/templates/records.ts Outdated Show resolved Hide resolved
src/standardise_records.ts Outdated Show resolved Hide resolved
src/standardise_records.ts Outdated Show resolved Hide resolved
src/templates/record.vue Outdated Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 3, 2019

@MattIPv4
Copy link
Member

left a comment

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 3, 2019

src/templates/record_jumps.vue Outdated Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 3, 2019

@MattIPv4
Copy link
Member

left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit 2ed8d61 into master Sep 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MattIPv4 MattIPv4 deleted the sshfp_tlsa branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.