Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMARC record explainer (Fixes #40) #74

Merged
merged 10 commits into from Sep 5, 2019

Conversation

@JakeMakesStuff
Copy link
Member

commented Sep 4, 2019

No description provided.

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 4, 2019

@MattIPv4
Copy link
Member

left a comment

We should also provide a single modal that contains all the DMARC tags and what they do, for someone who wishes to learn about DMARC records.

src/i18n/en/data/dmarc.ts Outdated Show resolved Hide resolved
src/i18n/en/data/dmarc.ts Outdated Show resolved Hide resolved
src/i18n/en/data/dmarc.ts Outdated Show resolved Hide resolved
src/i18n/en/data/dmarc.ts Outdated Show resolved Hide resolved
src/standardise_records.ts Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 4, 2019

src/i18n/en/data/dmarc.ts Outdated Show resolved Hide resolved

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Sep 5, 2019

@MattIPv4
Copy link
Member

left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit 719b56a into master Sep 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MattIPv4 MattIPv4 deleted the dmarc branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.