Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions to Helm charts (fixes #16) #18

Merged
merged 20 commits into from Dec 2, 2019

Conversation

@JakeMakesStuff
Copy link
Member

JakeMakesStuff commented Nov 11, 2019

Type of Change

  • Tool Source: Vue

What issue does this relate to?

Fixes #16

What should this PR do?

Add autosuggestion to Helm charts:
image

What are the acceptance criteria?

Do you like how it looks?

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on c25f619 Nov 8, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 3aac37c Nov 8, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 27397d0 Nov 8, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on c9a5f66 Nov 11, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Removing it is probably best
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on e0d1e08 Nov 11, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 2e7f3d1 Nov 11, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 0479d16 Nov 11, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 6719f37 Nov 11, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 11, 2019
Copy link
Member

MattIPv4 left a comment

image

  1. Can the suggestions have a hover style?
  2. Can you ensure the suggestions work properly with pressing tab over them for a11y?
  3. Can the suggestions block be given a background?

image

  1. Typing something and then clearing the search box results in this, which seems wrong?
Before After
image image
  1. Can the button be moved back inline, please?
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on a6ff0e8 Nov 12, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 99d6686 Nov 12, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 059c3bf Nov 12, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 2d13bc6 Nov 12, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 14aed36 Nov 12, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 12, 2019
Copy link
Member

MattIPv4 left a comment

It seems there still isn't a solid background on the suggestions, as you can see bits of the splash design leaking through:

image

I think it would make sense to make the autosuggest work so that someone could type rethink and it'd autosuggest stable/rethinkdb?

image

If you click on the input again once it has started loading, auto suggest pops back up and is still live. We should disable the input once it starts loading to avoid this:

image

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 8e79f98 Nov 26, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 26, 2019
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on cc501bb Nov 26, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 72f60ce Nov 26, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on fdaaafe Nov 29, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on dac5602 Nov 29, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 430727b Nov 29, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 29, 2019
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 9aa222b Nov 29, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Copy link
Member

MattIPv4 left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit 3346be7 into master Dec 2, 2019
1 check passed
1 check passed
build
Details
@MattIPv4 MattIPv4 deleted the suggest branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.