Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits from the community tools meeting (change font size and make it all single page for Helm) #23

Open
wants to merge 20 commits into
base: master
from

Conversation

@JakeMakesStuff
Copy link
Member

JakeMakesStuff commented Dec 4, 2019

Type of Change

  • Tool Source: Vue source

What issue does this relate to?

Fixes: #11

What should this PR do?

  • change font size
  • Make it all single page for Helm
  • Add back button
  • Add reference links
  • Add explainer on homepage
  • Add basic left rail navigation (although needs extra design)
  • accordian style listing
  • Collapsable with collapse all button

What are the acceptance criteria?

Do you like how it is handled?

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 3037762 Dec 3, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Still a lot to do with styling, but adds the basic logic
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 9afac23 Dec 3, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on c54f550 Dec 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Dec 4, 2019
Copy link
Member

MattIPv4 left a comment

Lgtm but we should wait for a design from @AmNotADev before continuing with building the single page layout.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 2781b55 Jan 6, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 36e1ea2 Jan 7, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on ca82e09 Jan 9, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Jan 9, 2020
Copy link
Member

MattIPv4 left a comment

  1. Using stable/rethinkdb, if I click on the admin-service to collapse it, this works. If I then click on the cluster-service, I need to click twice before it will collapse. This should only need one click?

  2. Maybe @AmNotADev has some ideas here, I think we could improve the names to make them a bit more "button"-like and perhaps look at animating the collapse or something. It feels very jarring at present.

  3. Pressing the return to main menu button does not wipe the URL query parameter.

  4. Implement quick jump links (like in the DNS tool) in the header that allows for quick jumping to each category (URL anchors, can be deep-linked to one).

  5. Further, add URL anchors for each file (based on name) that can also be deep-linked to. If this is done, all other files should auto-collapse on load.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 1bebc8c Jan 13, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 24fb910 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 5743d89 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 5a1c3a2 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on e25ac80 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on ee9ae36 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 47ed070 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on f378c0f Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff

This comment has been minimized.

Copy link
Member Author

JakeMakesStuff commented Jan 14, 2020

Note for Matt: As we discussed, the do-vue buttons seem to have a styling bug

@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Jan 14, 2020
when it's not there, it behaves like usual, when it's there it fails to build
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 0270491 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 38fb100 Jan 14, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
src/kubernetes-tool/templates/app.vue Outdated Show resolved Hide resolved
src/kubernetes-tool/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/templates/app.vue Show resolved Hide resolved
src/kubernetes-tool/templates/categorisation_view.vue Outdated Show resolved Hide resolved
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 0865d2b Jan 15, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 1047782 Jan 15, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on c042538 Jan 15, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
I was playing with this to look for another solution, but popping this path seems to look better imo
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Jan 15, 2020
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 167537b Jan 15, 2020

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.