Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator to inputs #7

merged 4 commits into from Nov 1, 2019


Copy link

MattIPv4 commented Nov 1, 2019

Type of Change

  • Tool Source: Vue

What issue does this relate to?


What should this PR do?

Adds a loading indicator to both inputs used in the tool splash screen.

What are the acceptance criteria?

  • Loading indicator shows when input is submitted
  • Loading indicator stops once loading is complete (return to main menu & inpput again to confirm)
  • Loading indicator stops if an error occurs (return to main menu & inpput again to confirm)

This comment has been minimized.

Copy link

github-actions bot commented on d6d27e9 Nov 1, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

@MattIPv4 MattIPv4 self-assigned this Nov 1, 2019
@MattIPv4 MattIPv4 merged commit 3abcfd5 into master Nov 1, 2019
1 check passed
1 check passed
@MattIPv4 MattIPv4 deleted the add-loading-indicator branch Nov 1, 2019
MattIPv4 added a commit that referenced this pull request Nov 5, 2019
* Add loading indicator to Helm input

* Add loading indicator to K8s input

* i18n Submit button text

* Fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.