New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctoolchain.bat is missing in https://github.com/docToolchain/docToolchain.git #131

Closed
tkleiber opened this Issue Jan 4, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@tkleiber

tkleiber commented Jan 4, 2018

Expected behavior and actual behavior.

In https://doctoolchain.github.io/docToolchain/#_build is stated that doctoolchain.bat has to be called on windows, but this does not exist in the cloned repository and so cannot be called.

Steps to reproduce the problem.

Clone https://github.com/docToolchain/docToolchain.git or download and unzip https://github.com/docToolchain/docToolchain/archive/master.zip

Search for doctoolchain.bat, it is not found.

The found bash script bin\doctoolchain cannot be called on windows.

Specifications like the version of the project, operating system, or hardware.

Commit: 1a025a0 [1a025a0]
Parents: b800cb6, 43e84d1
Author: Ralf D. Müller ralf.d.mueller@gmail.com
Date: Dienstag, 5. Dezember 2017 18:31:00
Windows 10

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Jan 5, 2018

thanx for reporting this!

docToolchain was initially build as gradle script and this approach is still the default one.
@jakubjab added a bash script to use docToolchain independently from gradle and the location of docToolchain, but a .bat or powershellscript is still missing. The documentation is already one step ahead :-|

On windows, it should still be possible to just cd to the docToolchain project folder and use ./gradlew.bat with the corresponding commands, e.g.

./gradlew.bat generateHTML

I'll see what I can do to come up with a .bat file which will fix this.

rdmueller added a commit that referenced this issue Jan 5, 2018

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Jan 5, 2018

I just added a .bat file which should do the trick. Can you give it a try?

@tkleiber

This comment has been minimized.

tkleiber commented Jan 5, 2018

This works fine when running in the docDir, but not when running from anywhere else, eg. from docToolchain\bin directory.

image 1

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Jan 5, 2018

Thank for testing.
I will try to fix this and cover it with a test

rdmueller added a commit to rdmueller/forked_docToolchain that referenced this issue Jan 24, 2018

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Jan 24, 2018

sorry, this took a while. The current version has already been tested by me.
please re-open if it doesn't work for you...

@rdmueller rdmueller closed this Jan 24, 2018

rdmueller added a commit that referenced this issue Jan 24, 2018

@tkleiber

This comment has been minimized.

tkleiber commented Jan 29, 2018

Error is furthermore reproducible, when running from outside docDir.

@rdmueller rdmueller reopened this Jan 29, 2018

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Jan 29, 2018

I'll try to reproduce it. Might be that I will come back to you to get it reproduced... :-)

@thokuest

This comment has been minimized.

thokuest commented Jan 29, 2018

Same issue here! I'd like to generate documents that are placed outside of the docToolchain project directory.

doctoolchain.bat doesn't support absolute path at the moment. %WORKINGDIR%%1 evaluates to a path underneath the working directory of the docToolchain project.

I think this can easily mitigated by replacing %WORKINGDIR%%1 with %~f1, see Resolve absolute path from relative path and/or file name.

rdmueller added a commit to rdmueller/forked_docToolchain that referenced this issue Feb 13, 2018

@rdmueller

This comment has been minimized.

Collaborator

rdmueller commented Feb 13, 2018

So, my solution is not as clean as the %~f1 solution, but at least I understand it better :-D

hope it works now and sorry for taking so long to resolve it...

reopen if it still does not work for you...

@rdmueller rdmueller closed this Feb 13, 2018

rdmueller added a commit that referenced this issue Feb 14, 2018

Merge pull request #141 from rdmueller/master
fix #131 : should now work with absolute and relative path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment