Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Add dotenv support #103

Merged
merged 3 commits into from Mar 13, 2019

Conversation

@c-w
Copy link
Member

c-w commented Mar 1, 2019

Resolves #94

Previously we were able to configure some aspects of the project via environment variables. This pull request adds the option to configure these settings in a .env file placed in the app/.env folder.

The implementation uses environs which wraps python-dotenv and adds a bunch of nice convenience methods such as automatic type casting and validation of environment variables (e.g. to convert from string to list or from string to boolean).

c-w added 2 commits Mar 1, 2019
This makes it more explicit that the environs module should be used to
access environment variables instead of `os.environ` or `os.getenv`
@c-w c-w mentioned this pull request Mar 1, 2019
@Hironsan Hironsan merged commit 2f59060 into doccano:master Mar 13, 2019
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@Hironsan

This comment has been minimized.

Copy link
Member

Hironsan commented Mar 13, 2019

Thanks!

@c-w c-w deleted the CatalystCode:enhancement/dotenv-support branch Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.