Enhancement/Integrate Webpack and Django#117
Merged
Hironsan merged 1 commit intodoccano:masterfrom Mar 25, 2019
Merged
Conversation
c-w
force-pushed
the
enhancement/webpack-in-django
branch
from
97b6426 to
07d5172
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #80.
This pull request more tightly integrates Django asset serving with the Webpack compiler. Specifically, after this change, it will no longer be required to manually compile the project's Javascript to integrate it with the Django server. Instead the Javascript will be compiled and reloaded on the fly automatically.
In a development scenario (here emulated by running the server as described in the README), the assets get linked via the hot reloading Webpack development server:
This enables a number of enhancements to the developer experience, including not having to manually run the Webpack build and also being able to debug Javascript before it went through the build process:
In a production scenario (here emulated by running the server via Docker), the assets get directly linked from the compiled static bundles folder as before: