Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Integrate Webpack and Django #117

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@c-w
Copy link
Member

c-w commented Mar 22, 2019

This is a follow-up to #80.

This pull request more tightly integrates Django asset serving with the Webpack compiler. Specifically, after this change, it will no longer be required to manually compile the project's Javascript to integrate it with the Django server. Instead the Javascript will be compiled and reloaded on the fly automatically.

In a development scenario (here emulated by running the server as described in the README), the assets get linked via the hot reloading Webpack development server:

Screenshot showing development asset loading

This enables a number of enhancements to the developer experience, including not having to manually run the Webpack build and also being able to debug Javascript before it went through the build process:

Screenshot showing debugging of Javascript before compilation

In a production scenario (here emulated by running the server via Docker), the assets get directly linked from the compiled static bundles folder as before:

Screenshot showing production asset loading

@c-w c-w force-pushed the CatalystCode:enhancement/webpack-in-django branch from 97b6426 to 07d5172 Mar 22, 2019
@Hironsan Hironsan merged commit a3635cf into doccano:master Mar 25, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Hironsan

This comment has been minimized.

Copy link
Member

Hironsan commented Mar 25, 2019

Thanks!

@c-w c-w deleted the CatalystCode:enhancement/webpack-in-django branch Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.