Enhancement/Turn dockerfile into a multi-stage build#118
Merged
Hironsan merged 1 commit intoMar 25, 2019
Merged
Conversation
Using a multi-stage build reduces the image size from 1.23GB to 331MB which means that any node running doccano can now start-up faster. Additionally, the multi-stage build means that we no longer include development tools like node or gcc in the production image which reduces the attack surface of the image.
c-w
force-pushed
the
enhancement/reduce-docker-image-size
branch
from
b25e1da to
c248e34
Compare
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a multi-stage build reduces the image size from 1.23GB to 331MB which means that any node running doccano can now start-up faster.
Additionally, the multi-stage build means that we no longer include in the production image development tools like node (now excluded since it's only installed in the builder layer) or gcc (now excluded since the production layer is based on python-slim) which reduces the attack surface of the image.