Enhancement/Run ESlint during CI#119
Merged
Merged
Conversation
c-w
force-pushed
the
enhancement/eslint-ci
branch
5 times, most recently
from
March 25, 2019 12:50
a4e5147 to
d8422f8
Compare
c-w
force-pushed
the
enhancement/eslint-ci
branch
from
March 25, 2019 12:51
d8422f8 to
e40a3e1
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lays some foundations for the Introduce JavaScript testing framework task mentioned in the Feature Ideas.
As a first step to ensure the quality of the JavaScript code, this pull request forces ESlint to be run during the CI. In the future once some JavaScript tests are included in the project, it will be very simple to extend the CI to also run the tests: just add another line similar to
npm run linttotools/ci.shand we're good to go.The pull request also fixes all the current simple ESlint failures and disables some others. In the future, I expect to re-activate some of the disabled rules and add more linting rules, e.g. for Vue, but for now I wanted to keep the changes small.
To make it easier to have access to all the CI requirements (Python, Node, etc.), this pull request also moves the Travis CI to be fully based on the Docker image so that we're in full control of the CI environment and can also very easily run the exact same CI steps which Travis executes locally as a developer.