Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Reduce scope of Swiper include #146

Merged

Conversation

@c-w
Copy link
Member

c-w commented Apr 9, 2019

Currently the Swiper library is referenced in the base template which means that its CSS and JS get included and loaded on every page. However, the Swiper functionality is only used on the landing page. This leads to redundant requests to load the CSS and JS and may even lead to hard to debug potential issues with clashing JS or CSS.

This change moves the Swiper JS and CSS to only be included on the landing page.

Currently the Swiper library is referenced in the base template which
means that its CSS and JS get included and loaded on every page.
However, the Swiper functionality is only used on the landing page. This
leads to redundant requests to load the CSS and JS and may even lead to
hard to debug potential issues with clashing JS or CSS.

This change moves the Swiper JS and CSS to only be included on the
landing page.
@Hironsan Hironsan merged commit 6341015 into doccano:master Apr 12, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:enhancement/reduce-swiper-include-scope branch Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.