Enhancement/Reduce scope of Swiper include #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Swiper library is referenced in the base template which means that its CSS and JS get included and loaded on every page. However, the Swiper functionality is only used on the landing page. This leads to redundant requests to load the CSS and JS and may even lead to hard to debug potential issues with clashing JS or CSS. This change moves the Swiper JS and CSS to only be included on the landing page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Swiper library is referenced in the base template which means that its CSS and JS get included and loaded on every page. However, the Swiper functionality is only used on the landing page. This leads to redundant requests to load the CSS and JS and may even lead to hard to debug potential issues with clashing JS or CSS.
This change moves the Swiper JS and CSS to only be included on the landing page.