Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesBugfix/Correctly display dataset upload errors #157
Merged
Conversation
When importing an invalid CSV file that fails data validation, the API returns the errors wrapped in an array. The current frontend code does not handle this case and does not display the errors which can be confusing for users as for example seen in #150. This change modifies the frontend code to handle error responses wrapped in an array. The code was tested by uploading the following CSV file: ``` text,label "","label1" ``` After applying the change, we now correctly render the upload error as shown in the screenshot below: [](https://user-images.githubusercontent.com/1086421/56042132-504f3300-5d08-11e9-8ddf-04c8deb2f60b.png)
](https://user-images.githubusercontent.com/1086421/56042132-504f3300-5d08-11e9-8ddf-04c8deb2f60b.png){kind=link}
This comment has been minimized.
This comment has been minimized.
|
Thanks! Additionally, I made the checklist for the same situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedApr 12, 2019
When importing an invalid CSV file that fails data validation, the API returns the errors wrapped in an array. The current frontend code does not handle this case and does not display the errors which can be
confusing for users as for example seen in #150.
This change modifies the frontend code to handle error responses wrapped in an array. The code was tested by uploading the following CSV file:
After applying the change, we now correctly render the upload error as shown in the screenshot below: