Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement/Add button to delete documents on dataset page #193
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedMay 13, 2019
This change adds a button the the dataset page which lets an admin delete documents from a project. This is useful to for example delete test data or clean up the dataset.
The button is implemented via a simple request to the existing delete endpoint in the documents API. Given that the dataset page is server-side rendered by Django, when the request is successful, we reload the page to reflect the new state of the dataset. Note that for simplicity and speed, the button does not prompt the user for confirmation.
Resolves #21