Bugfix/Fix multiple display of completed items #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #172, there is an issue in the completed filter where each document is included once per annotation in the document. See screenshot below for an example where a document is included 4 times in the list:
The root cause of the problem is that the current filtering approach with
{column_name}__isnull
generates an inner join between the documents and annotations table which leads to the behavior of having one copy of the document per annotation.This change fixes the behavior and ensures that each document is only included once in the completed list by using an explicit group by and count filter on the number of annotations:
Ideally we'd use
queryset.distinct('id')
instead of the group by count approach, but unfortunately this is currently only supported by Postgres.Resolves #172